Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_ec2_traffic_mirror_target: Correct arn #17973

Conversation

shuheiktgw
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #16978

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEc2TrafficMirrorTarget_nlb'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEc2TrafficMirrorTarget_nlb -timeout 120m
=== RUN   TestAccAWSEc2TrafficMirrorTarget_nlb
=== PAUSE TestAccAWSEc2TrafficMirrorTarget_nlb
=== CONT  TestAccAWSEc2TrafficMirrorTarget_nlb
--- PASS: TestAccAWSEc2TrafficMirrorTarget_nlb (505.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	507.174s

Thank you for your review! 👍

@shuheiktgw shuheiktgw requested a review from a team as a code owner March 7, 2021 23:52
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 7, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 7, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEc2TrafficMirrorTarget_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSEc2TrafficMirrorTarget_ -timeout 120m
=== RUN   TestAccAWSEc2TrafficMirrorTarget_nlb
=== PAUSE TestAccAWSEc2TrafficMirrorTarget_nlb
=== RUN   TestAccAWSEc2TrafficMirrorTarget_eni
=== PAUSE TestAccAWSEc2TrafficMirrorTarget_eni
=== RUN   TestAccAWSEc2TrafficMirrorTarget_tags
=== PAUSE TestAccAWSEc2TrafficMirrorTarget_tags
=== RUN   TestAccAWSEc2TrafficMirrorTarget_disappears
=== PAUSE TestAccAWSEc2TrafficMirrorTarget_disappears
=== CONT  TestAccAWSEc2TrafficMirrorTarget_nlb
=== CONT  TestAccAWSEc2TrafficMirrorTarget_disappears
--- PASS: TestAccAWSEc2TrafficMirrorTarget_disappears (212.93s)
=== CONT  TestAccAWSEc2TrafficMirrorTarget_tags
--- PASS: TestAccAWSEc2TrafficMirrorTarget_nlb (215.07s)
=== CONT  TestAccAWSEc2TrafficMirrorTarget_eni
--- PASS: TestAccAWSEc2TrafficMirrorTarget_eni (200.74s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_tags (272.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	486.024s

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 8, 2021
@breathingdust
Copy link
Member

LGTM 🚀 Thanks @shuheiktgw!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEc2TrafficMirrorTarget_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSEc2TrafficMirrorTarget_ -timeout 120m
=== RUN   TestAccAWSEc2TrafficMirrorTarget_nlb
=== PAUSE TestAccAWSEc2TrafficMirrorTarget_nlb
=== RUN   TestAccAWSEc2TrafficMirrorTarget_eni
=== PAUSE TestAccAWSEc2TrafficMirrorTarget_eni
=== RUN   TestAccAWSEc2TrafficMirrorTarget_tags
=== PAUSE TestAccAWSEc2TrafficMirrorTarget_tags
=== RUN   TestAccAWSEc2TrafficMirrorTarget_disappears
=== PAUSE TestAccAWSEc2TrafficMirrorTarget_disappears
=== CONT  TestAccAWSEc2TrafficMirrorTarget_nlb
=== CONT  TestAccAWSEc2TrafficMirrorTarget_disappears
--- PASS: TestAccAWSEc2TrafficMirrorTarget_nlb (204.33s)
=== CONT  TestAccAWSEc2TrafficMirrorTarget_tags
--- PASS: TestAccAWSEc2TrafficMirrorTarget_disappears (214.74s)
=== CONT  TestAccAWSEc2TrafficMirrorTarget_eni
--- PASS: TestAccAWSEc2TrafficMirrorTarget_eni (95.66s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_tags (254.43s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	461.573s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEc2TrafficMirrorTarget_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSEc2TrafficMirrorTarget_ -timeout 120m
=== RUN   TestAccAWSEc2TrafficMirrorTarget_nlb
=== PAUSE TestAccAWSEc2TrafficMirrorTarget_nlb
=== RUN   TestAccAWSEc2TrafficMirrorTarget_eni
=== PAUSE TestAccAWSEc2TrafficMirrorTarget_eni
=== RUN   TestAccAWSEc2TrafficMirrorTarget_tags
=== PAUSE TestAccAWSEc2TrafficMirrorTarget_tags
=== RUN   TestAccAWSEc2TrafficMirrorTarget_disappears
=== PAUSE TestAccAWSEc2TrafficMirrorTarget_disappears
=== CONT  TestAccAWSEc2TrafficMirrorTarget_nlb
=== CONT  TestAccAWSEc2TrafficMirrorTarget_disappears
--- PASS: TestAccAWSEc2TrafficMirrorTarget_disappears (205.86s)
=== CONT  TestAccAWSEc2TrafficMirrorTarget_eni
--- PASS: TestAccAWSEc2TrafficMirrorTarget_nlb (217.13s)
=== CONT  TestAccAWSEc2TrafficMirrorTarget_tags
--- PASS: TestAccAWSEc2TrafficMirrorTarget_eni (90.63s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_tags (237.64s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	457.636s

@breathingdust breathingdust merged commit 2c4c3a8 into hashicorp:main Mar 17, 2021
@ghost
Copy link

ghost commented Apr 17, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants